Skip to content
This repository was archived by the owner on Oct 5, 2023. It is now read-only.
This repository was archived by the owner on Oct 5, 2023. It is now read-only.

Not compatible with github.com/ipfs/[email protected] #167

Closed
@kylos101

Description

@kylos101

Description

Projects that depend on ipfs/[email protected] cannot use ipfs/[email protected]. If we try, we get errors like:

go build .
# github.com/libp2p/go-libp2p-core/network
../../../go/pkg/mod/github.com/libp2p/[email protected]/network/rcmgr.go:166:27: network.NullResourceManager (type) is not an expression

go mod why github.com/libp2p/go-libp2p-core/network
# github.com/libp2p/go-libp2p-core/network
github.com/ipfs/go-ipfs-http-client
github.com/libp2p/go-libp2p-core/network

ipfs/go-ipfs-http-client depends on:

github.com/ipfs/interface-go-ipfs-core v0.7.0

Which depends on:

github.com/libp2p/go-libp2p-core v0.8.6

But is archived and contains deprecated methods like:

https://github.com/libp2p/go-libp2p-core/blob/654214c1b3401c0363ef464ce9db7e1b04a7ef3f/network/rcmgr.go#L165-L166

Potential next steps?

  1. Refactor ipfs/interface-go-ipfs-core to depend on github.com/libp2p/[email protected], and use its core package instead of github.com/libp2p/[email protected]
  2. Update ipfs/go-ipfs-http-client to use the new ipfs/interface-go-ipfs-core using github.com/libp2p/[email protected]

Anything else

I wanted to surface an issue to the community to get it's corresponding guidance. Let me know what you think? 🙏

Metadata

Metadata

Assignees

Labels

P0Critical: Tackled by core team ASAPdependenciesPull requests that update a dependency file

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions