fix(cli/parse): extract dir before name #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jorropo
previously requested changes
Apr 13, 2022
There was a problem hiding this comment.
The change looks good, however this error message is terribely spammy:
Error: file name x repeated under different import directories: dir2 and dir1
USAGE
ipfs add <path>... - Add a file or directory to IPFS.
ipfs add [--recursive | -r] [--dereference-args] [--stdin-name=<stdin-name>] [--hidden | -H] [--ignore=<ignore>]... [--ignore-rules-path=<ignore-rules-path>] [--quiet | -q] [--quieter | -Q] [--silent]
[--progress | -p] [--trickle | -t] [--only-hash | -n] [--wrap-with-directory | -w] [--chunker=<chunker> | -s] [--pin=false] [--raw-leaves] [--nocopy] [--fscache] [--cid-version=<cid-version>]
[--hash=<hash>] [--inline] [--inline-limit=<inline-limit>] [--] <path>...
Adds the content of <path> to IPFS. Use -r to add directories (recursively).
For more information about each command, use:
'ipfs add <subcmd> --help'
Dumping the help isn't helpfull and dilute the signal.
I would expect the same thing as other APIs:
$ ./ipfs pin add Qmfoo
Error: invalid path "Qmfoo": selected encoding not supported
|
@Jorropo I don't understand exactly what's your requested change here. The above is the behavior for any command error, e.g., |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syncing to commit protocol/.github@2aab7c0.