Skip to content

Conversation

achingbrain
Copy link
Member

@diasdavid gave some insight as to the preferred use of ~ vs ^ in package.json dependency versions in this PR so let's add it to the JS guidelines to make sure it doesn't get lost.

@ghost ghost assigned achingbrain May 1, 2018
@ghost ghost added the status/in-progress In progress label May 1, 2018
@daviddias daviddias changed the base branch from master to module-lead-maintainers May 1, 2018 11:54
@daviddias
Copy link
Member

@achingbrain thanks for adding this. I changed the target to be js-code-guidelines given that is a new version and to avoid dealing with merge conflicts now that the guidelines shuffled so much. Could you update your PR?. Thank you!

@achingbrain achingbrain force-pushed the add-dep-versioning-note branch from 182029c to 40b84f6 Compare May 1, 2018 12:03
@achingbrain
Copy link
Member Author

@diasdavid done!

@daviddias daviddias merged commit 635c361 into module-lead-maintainers May 1, 2018
@daviddias daviddias deleted the add-dep-versioning-note branch May 1, 2018 13:02
@ghost ghost removed the status/in-progress In progress label May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants