fix: test external modules that have transitive dep on ipfs #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goes some way to address ipfs/js-ipfs#2542 in that it changes our definition of how a module 'depends' on IPFS. If it's in your `node_modules` folder, it'll get upgrade to the current release we are testing. This means if we're testing module `A` and `A` has a depdendency graph like `A -> B -> C -> ipfs`, as long as `ipfs` has been hoisted to the the top level `node_modules` folder, we'll swap it out with the new version we're trying to release. It also dedupes `ipfs` and `ipfs-http-client` in the dep tree so we can be sure we're testing against our `rc`, though this may cause problems where intermediate deps need updating, but at least the need for them to be updated will be visible.
|
We should only test direct dependents !! |
I agree, and am more than happy to have this PR closed without it being merged (see my comments on ipfs/js-ipfs#2542) because doing it this way doesn't really guarantee anything about the modules we test. |
|
Closing this, feel free to re-open if you think we should revisit this. |
achingbrain
deleted the
test-externals-with-transitive-dependency-on-ipfs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes some way to address ipfs/js-ipfs#2542 in that it changes our definition of how a module 'depends' on IPFS.
Previously it had to be in your
package.json. Now If it's in yournode_modulesfolder, it'll get upgraded to the current release we are testing.This means if we're testing module
AandAhas a depdendency graph likeA -> B -> C -> ipfs, as long asipfshas been hoisted to the the top levelnode_modulesfolder, we'll swap it out with the new version we're trying to release.It also dedupes
ipfsandipfs-http-clientin the dep tree so we can be sure we're testing against ourrc, though this may cause problems where intermediate deps need updating, but at least the need for them to be updated will be visible.