name_resolve should be an ArgCommand, not a Command #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming that I am trying to use name_resolve correctly:
>>> api.name_resolve('QmXfrS3pHerg44zzK6QKQj6JDk8H6cMtQS7pdXbohwNQfK')
It looks as if it needs to be specified as an `ArgCommand`, rather than
as a `Command`.
Closes ipfs-shipyard#4.
|
+1 just spent half an hour figuring out we should make this change and you beat me to the commit. This indicates we should also add a "did this command throw an exception when given sane input" baseline test. |
amstocker
added a commit
that referenced
this pull request
Sep 10, 2015
name_resolve should be an ArgCommand, not a Command
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that I am trying to use name_resolve correctly:
It looks as if it needs to be specified as an
ArgCommand, rather thanas a
Command.