Skip to content

Add log and bitswap cmd #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add log and bitswap cmd #47

wants to merge 2 commits into from

Conversation

fredthomsen
Copy link
Contributor

Added more API commands to improve this relative to js-ipfs-api as mentioned by #42.

@whereswaldon
Copy link
Contributor

I wish we'd known that you were doing those log commands. My team just implemented them as well #46 , but we don't have the bitswap stuff. We do have tests for the log functionality though.

@fredthomsen
Copy link
Contributor Author

fredthomsen commented Jul 23, 2016

No worries. How would you like to move forward and do you need any help?

EDIT: Saw you have also resolved the test failure in test_file_command_fd. Nice.

@whereswaldon
Copy link
Contributor

whereswaldon commented Jul 24, 2016 via email

@ntninja
Copy link
Contributor

ntninja commented Aug 10, 2016

Since @whereswaldon's log command has landed…

Could you open a new MR @fredthomsen with just the bitswap commit and (if you have the time for it) an accompanying unit test?
Thanks for helping out!

@whereswaldon
Copy link
Contributor

@fredthomsen Really would love to merge your bitswap commands. Do you have time to write some tests and submit a new PR?

@fredthomsen
Copy link
Contributor Author

Yes. I'll re-open a separate pull request as suggested.

@whereswaldon whereswaldon mentioned this pull request Aug 15, 2016
@fredthomsen fredthomsen mentioned this pull request Aug 15, 2016
@fredthomsen
Copy link
Contributor Author

#55 will replace this PR for the bitswap commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants