Allow specifying destination directory and filename in get() #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying the destination directory, but not the name of the file.
ntninja
requested changes
Feb 6, 2019
| @@ -307,6 +313,11 @@ def download(self, path, args=[], filepath=None, opts={}, | |||
| with tarfile.open(fileobj=res.raw, mode=mode) as tf: | |||
| tf.extractall(path=wd) | |||
There was a problem hiding this comment.
Please iterate over the fsnodes of the received tar file using TarFile.next(), extracting each of them using them using the TarFile.extract() method rather then moving them around like this after the fact.
| Defaults to the current working directory. | ||
| If the directory does not exist, it will be created. | ||
| filename : str | ||
| The filename to store the file as. |
There was a problem hiding this comment.
Why do we need two parameters here? Why not just have a path relative to the current working directory whose basename will be the filename of the object to download (meaning that the file at the path will be either a file or a directory depending on its actual type)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #48 , #110