[WIP] Improve, fix and finish #45
Conversation
|
@dignifiedquire ready for review? |
|
@diasdavid not really, currently working on improving test coverage |
package.json
Outdated
| "http-https": "^1.0.0", | ||
| "express": "^4.14.0", | ||
| "follow-registry": "^3.1.0", | ||
| "ipfs-api": "^9.0.0", |
There was a problem hiding this comment.
it was up to date when I wrote this :P
package.json
Outdated
| "devDependencies": { | ||
| "abstract-blob-store": "^3.2.0", | ||
| "assert": "^1.3.0", | ||
| "aegir": "^8.1.2", |
There was a problem hiding this comment.
Since you are adding aegir, let's start with aegir 9
src/ipfs-npm/registry/clone/index.js
Outdated
| } | ||
|
|
||
| if (opts.seqNumber) { | ||
| // TODO: what to do? |
There was a problem hiding this comment.
start from that seq number forward.
seqnumber is a stored value on disk, so that it is easy to resume
| if (opts.seqNumber) { | ||
| // TODO: what to do? | ||
| followConf.since = opts.seqNumber | ||
| } |
There was a problem hiding this comment.
name changing things? seqNumber was pretty good because it is the number that comes from npm too
There was a problem hiding this comment.
@diasdavid since is the name follow-registry understands, passing seqNumber wouldn't work
|
@dignifiedquire going to merge this. It has become such a long PR, it gets easier to track if only a single PR with the check boxes :) (specially for other people that want to try it out) |
|
Sure :) |
I started working on this last night and will continue on this over the next weeks, as I really want to use this