This repository was archived by the owner on Mar 10, 2020. It is now read-only.
fix: support count as well as length
#27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
fixes #21 Some userland applications switch between go and js implementations at will. Go prefers `offset`/`count`, the interface spec says it should be `offset`/`length`. Bend like a reed in the wind and support both. License: MIT Signed-off-by: achingbrain <[email protected]>
achingbrain
force-pushed
the
support-count-argument
branch
from
435115a to
e787bf9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21
Some userland applications switch between go and js implementations at will. Go prefers
offset/countforfiles.read, the interface spec says it should beoffset/length. Bend like a reed in the wind and support both.License: MIT
Signed-off-by: achingbrain [email protected]