Skip to content
This repository was archived by the owner on Mar 10, 2020. It is now read-only.

docs: add dry-run config test and change new/old for original/updated #539

Merged
merged 1 commit into from
Oct 4, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SPEC/CONFIG.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ If no callback is passed, a [promise][] is returned
**Example:**

```JavaScript
ipfs.config.profiles.list(newConfig, (err, profiles) => {
ipfs.config.profiles.list((err, profiles) => {
if (err) {
throw err
}
Expand Down Expand Up @@ -135,8 +135,8 @@ ipfs.config.profiles.apply('lowpower', (err, diff) => {
throw err
}

console.info(diff.old)
console.info(diff.new)
console.info(diff.original)
console.info(diff.updated)
})
```

Expand Down
25 changes: 23 additions & 2 deletions src/config/profiles/apply.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,32 @@ module.exports = (createCommon, options) => {
(cb) => ipfs.config.profiles.apply('lowpower', cb),
(_diff, cb) => {
diff = _diff
expect(diff.old.Swarm.ConnMgr.LowWater).to.not.equal(diff.new.Swarm.ConnMgr.LowWater)
expect(diff.original.Swarm.ConnMgr.LowWater).to.not.equal(diff.updated.Swarm.ConnMgr.LowWater)
ipfs.config.get(cb)
},
(newConfig, cb) => {
expect(newConfig.Swarm.ConnMgr.LowWater).to.equal(diff.new.Swarm.ConnMgr.LowWater)
expect(newConfig.Swarm.ConnMgr.LowWater).to.equal(diff.updated.Swarm.ConnMgr.LowWater)
cb()
}
], done)
})

it('should not apply a config profile in dry-run mode', (done) => {
let originalConfig
waterfall([
(cb) => ipfs.config.get(cb),
(config, cb) => {
originalConfig = config
cb()
},
(cb) => ipfs.config.profiles.apply('server', { dryRun: true }, cb),
(diff, cb) => {
expect(diff.original).to.deep.equal(originalConfig)
expect(diff.updated).to.not.deep.equal(originalConfig)
ipfs.config.get(cb)
},
(updatedConfig, cb) => {
expect(updatedConfig).to.deep.equal(originalConfig)
cb()
}
], done)
Expand Down