This repository was archived by the owner on Mar 10, 2020. It is now read-only.
docs: add dry-run config test and change new/old for original/updated #539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also corrects `ipfs.config.profiles.list` example. BREAKING CHANGE: `ipfs.config.profiles.apply` now returns `original`/`updated` keys in the diff because using `new` stops us from destructuring in js.
achingbrain
force-pushed
the
add-dry-run-test
branch
from
dcf24f2 to
e206aa7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects
ipfs.config.profiles.listexample.BREAKING CHANGE:
ipfs.config.profiles.applynow returnsoriginal/updatedkeys in the diff because usingnewstops us from destructuring in js.Sort of breaking, no implementation for this has been published yet.