This repository was archived by the owner on May 20, 2025. It is now read-only.
-
Couldn't load subscription status.
- Fork 82
added a convert tool between bech32 and hex #1502
Open
hackphobic
wants to merge
16
commits into
iotaledger-archive:shimmer-develop
Choose a base branch
from
hackphobic:shimmer-develop
base: shimmer-develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
added a convert tool between bech32 and hex #1502
hackphobic
wants to merge
16
commits into
iotaledger-archive:shimmer-develop
from
hackphobic:shimmer-develop
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibault-martinez
suggested changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, can you fix the clippy warnings please?
|
@thibault-martinez done! the licenses test seems to be failing on one of the imported crates. |
Yeah don't worry about that. I'll review tonight or tomorrow, thanks. |
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
Co-authored-by: Thibault Martinez <[email protected]>
Thoralf-M
reviewed
Sep 10, 2022
Thoralf-M
reviewed
Sep 10, 2022
Thoralf-M
reviewed
Sep 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Added a conversion tool between Bech32, Hex and public key encoding.
Links to any relevant issues
#263
Type of change
How the change has been tested
I included 3 unit tests for each function. The conversions are available in the spec page https://github.com/iotaledger/tips/blob/main/tips/TIP-0011/tip-0011.md
Change checklist