Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Conversation

@hackphobic
Copy link
Collaborator

Description of change

Added a conversion tool between Bech32, Hex and public key encoding.

Links to any relevant issues

#263

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

I included 3 unit tests for each function. The conversions are available in the spec page https://github.com/iotaledger/tips/blob/main/tips/TIP-0011/tip-0011.md

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes
  • I have updated the CHANGELOG.md, if my changes are significant enough

Copy link
Collaborator

@thibault-martinez thibault-martinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, can you fix the clippy warnings please?

@hackphobic
Copy link
Collaborator Author

hackphobic commented Aug 29, 2022

@thibault-martinez done! the licenses test seems to be failing on one of the imported crates.

@thibault-martinez
Copy link
Collaborator

@thibault-martinez done! the licenses test seems to be failing for one of the imported crate.

Yeah don't worry about that. I'll review tonight or tomorrow, thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants