This repository was archived by the owner on Sep 15, 2021. It is now read-only.
Added PushPlugin 'hasPermission' method to cordovaPushV5 #1335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Build failure should be fixed by #1329 |
moskeyombus
force-pushed
the
add-push-plugin-has-permission
branch
from
91d64e8 to
e65137c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #1333
Problem
(https://github.com/phonegap/phonegap-plugin-push/blob/master/docs/API.md#pushnotificationhaspermissionsuccesshandler---android--ios-only)
phonegap-plugin-pushhas a method calledhasPermissionthat can be used to determine whether or not a user has allowed push notifications for a specific app in iOS/Android settings. ngCordova's implementation of this plugin does not include this method.Solution
Added a
hasPermissionmethod to cordovaPushV5. Also, there were no specs for cordovaPushV5, so I added a spec file and wrote specs forinitandhasPermission.Details
I wanted to open this PR and get feedback before writing the entire spec suite for $cordovaPushV5, but I'd be happy to either add that here or open another PR. Also, $cordovaPushV5 appears to not have any mocks in place, same thing, can add here or open another PR for those as well.