This repository was archived by the owner on Sep 15, 2021. It is now read-only.
chore(npm): remove fs npm package #1330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
the base branch needs to be changed to |
The module `fs` is not actually needed to require the standard library `fs`. This module was temporarily wiped, since the whole module only consists out of a single `console.log(...)` [1]. [1] http://status.npmjs.org/incidents/dw8cr1lwxkcr
fh1ch
force-pushed
the
chore/remove-fs-module
branch
from
4034a1d to
ed84bbf
Compare
Author
|
@gortok I've rebased and changed the source branch onto @NiklasMerz thanks for the message / reference 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module
fsis not actually needed to require the standard libraryfs. This module was temporarily wiped, since the whole module only consistsout of a single
console.log(...)[1].[1] http://status.npmjs.org/incidents/dw8cr1lwxkcr