Skip to content
This repository was archived by the owner on Sep 15, 2021. It is now read-only.

Conversation

@fantapop
Copy link

Exit after rejecting the promise so we don't continue to try and use navigator.accelerometer which is undefined.

@gortok
Copy link
Contributor

gortok commented Jan 15, 2016

This isn't a bad idea; but we need better logic here; there should be conditional logic if/else around so you're not using the plugin if it's undefined. A little more extensive work would need to be done against this PR to have to included.

@fantapop
Copy link
Author

I'm not really following. By returning the rejected promise, the plugin will not be used.

@gortok gortok merged commit 82be9be into ionic-team:dev-next Sep 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants