-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(modal): dismiss keyboard on drag card modal #30020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This is a breaking change for my use case, where users desire the keyboard to remain present. A better solution would be adding onDragStart event to modal so developers can customize behavior - see: #23955 (comment) |
@aeharding actually, this is exactly the same behavior as the sheet modal; which closes the keyboard on drag. Can you show me an example of your use case? |
For example, iOS mail, if you pull down an email slightly the keyboard stays visible. |
@aeharding do you think that we can add a prop to conditionally activate this feature? Like having a |
Hey! Thanks for the PR! I think I do agree with @aeharding here that this may not be desired behavior. As he suggested on the linked issue (and here), I think we'd prefer an event be emitted on drag start/end so developers can rig up their own event handling to do what they want - in your case, dismiss the keyboard. I wouldn't even be opposed to this just being an optional property to enable keyboard dismiss on drag, but I still think an event being emitted on drag events would be a much nicer way to go |
Issue number: resolves #30019
What is the current behavior?
Dragging a card modal on iOS while the keyboard is open does not close the keyboard.
What is the new behavior?
Dragging a card modal closes the keyboard.
Does this introduce a breaking change?
Other information
ScreenRecording_11-14-2024.13-51-10_1.mov
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-14.at.14.54.03.mp4