refactor(react): update tab-bar requirement on tabs #29868
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
As mentioned in this PR, React
IonTabs
requiresIonTabBar
do be a child, else it doesn't render and throws an error.Angular, JS, and Vue doesn't have this requirement.
What is the new behavior?
I didn't see any reason why React does not mimic the other frameworks. In order to keep consistency, I've updated the React tabs. This would allow
ion-tabs
andion-tab-bar
can be used as standalone elements as mentioned in the docs.IonTabs
doesn't requireIonTabBar
to be a child to render.Does this introduce a breaking change?
Other information
Dev build: 8.3.1-dev.11726159792.1a6f49de
How to test:
IonTabBar
IonTabs
does not rendernpm install @ionic/[email protected]
IonTabBar
is still commented outIonTabs
renders