Skip to content

refactor(datetime): remove safari 14 hack #29035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 3 commits into from
Feb 13, 2024
Merged

refactor(datetime): remove safari 14 hack #29035

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28cce43
refactor(datetime): remove safari 14 hack
liamdebeasi Feb 13, 2024
91baf20
Merge branch 'feature-8.0' into FW-1823
liamdebeasi Feb 13, 2024
aa99c2f
Merge branch 'feature-8.0' into FW-1823
liamdebeasi Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 0 additions & 48 deletions core/src/components/datetime/datetime.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1662,14 +1662,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={todayString}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}

const { value } = ev.detail;
const findPart = parts.find(({ month, day, year }) => value === `${year}-${month}-${day}`);

Expand All @@ -1683,10 +1675,6 @@ export class Datetime implements ComponentInterface {
...findPart,
});

// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();

ev.stopPropagation();
}}
>
Expand Down Expand Up @@ -1793,14 +1781,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={pickerColumnValue}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}

this.setWorkingParts({
...workingParts,
day: ev.detail.value,
Expand All @@ -1811,10 +1791,6 @@ export class Datetime implements ComponentInterface {
day: ev.detail.value,
});

// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();

ev.stopPropagation();
}}
>
Expand Down Expand Up @@ -1848,14 +1824,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={workingParts.month}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}

this.setWorkingParts({
...workingParts,
month: ev.detail.value,
Expand All @@ -1866,10 +1834,6 @@ export class Datetime implements ComponentInterface {
month: ev.detail.value,
});

// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();

ev.stopPropagation();
}}
>
Expand Down Expand Up @@ -1902,14 +1866,6 @@ export class Datetime implements ComponentInterface {
disabled={disabled}
value={workingParts.year}
onIonChange={(ev: CustomEvent) => {
// TODO(FW-1823) Remove this when iOS 14 support is dropped.
// Due to a Safari 14 issue we need to destroy
// the scroll listener before we update state
// and trigger a re-render.
if (this.destroyCalendarListener) {
this.destroyCalendarListener();
}

this.setWorkingParts({
...workingParts,
year: ev.detail.value,
Expand All @@ -1920,10 +1876,6 @@ export class Datetime implements ComponentInterface {
year: ev.detail.value,
});

// We can re-attach the scroll listener after
// the working parts have been updated.
this.initializeCalendarListener();

ev.stopPropagation();
}}
>
Expand Down