feat(action-sheet): add htmlAttributes property for passing attributes to buttons #27863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brandyscarney
force-pushed
the
FW-4240-action-sheet
branch
from
d03a7b6 to
91d796c
Compare
brandyscarney
requested review from
a team and
liamdebeasi
and removed request for
a team
brandyscarney
commented
Jul 27, 2023
liamdebeasi
reviewed
Jul 27, 2023
liamdebeasi
reviewed
Jul 27, 2023
liamdebeasi
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: N/A
What is the current behavior?
Buttons containing only icons are not accessible as there is no way to pass an
aria-labelattribute (or any other html attribute).What is the new behavior?
htmlAttributesproperty on theActionSheetButtoninterfacehtmlAttributesto the buttons (both the buttons array and the cancelButton)aria-labelandaria-labelled-byare passed to a button with and without the cancel role - this was done because action sheet breaks these buttons up when renderingDoes this introduce a breaking change?