test(all): add await to relevant assertions #25527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
commented
Jun 23, 2022
| test.describe('modal: focus trapping', () => { | ||
| test.beforeEach(async ({ browserName }, testInfo) => { | ||
| test.skip(testInfo.project.metadata.rtl === true, 'This does not test LTR vs. RTL layout.'); | ||
| test.skip(browserName === 'firefox', 'Firefox incorrectly allows keyboard focus to move to ion-content'); |
There was a problem hiding this comment.
This was flaky before, but now that we have the await in place it was failing more often. This appears to be a Firefox bug
sean-perkins
approved these changes
Jun 23, 2022
|
Was the empty file at |
|
That was for something I was testing, but I forgot to remove the file. It's been removed now. |
averyjohnston
approved these changes
Jun 24, 2022
This was referenced Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
ionic-docsrepo, in a separate PR. See the contributing guide for details.npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Many of our assertions do not have the appropriate
awaitcausing certain test to be flaky. This is most often seen with focus tests where we need to test focus multiple times in a single test.What is the new behavior?
awaitNote that
toMatchSnapshotdoes not needawaitas it does not return a promise: https://playwright.dev/docs/test-assertions#screenshot-assertions-to-match-snapshot-1Does this introduce a breaking change?
Other information