Skip to content

Conversation

@sean-perkins
Copy link
Contributor

@sean-perkins sean-perkins commented Jun 21, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
    • Some docs updates need to be made in the ionic-docs repo, in a separate PR. See the contributing guide for details.
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When developers make use of routable standalone components with Ionic, they will receive a generic error that gives no context to the issue or current support status of the feature.

Issue URL: Internal

What is the new behavior?

  • Warn developers when they attempt to use standalone components with ion-router-outlet

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev-build: 6.1.11-dev.11655864040.13968d31

You can test with this demo repo and the dev-build: https://github.com/sean-perkins/angular-14-demo

Screen Shot 2022-06-21 at 10 24 49 PM

@sean-perkins sean-perkins requested a review from a team June 21, 2022 21:14
@github-actions github-actions bot added the package: angular @ionic/angular package label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants