Skip to content

Conversation

@sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The picker column is mutating the reference object for the column options. This causes the check that compares the transform value against the option's transform value, to skip applying the button transform values and the column items will overlap (on the second open with a selected value).

Issue URL: #17664

What is the new behavior?

  • Always apply the button transform for the option.
  • Picker renders correctly with a selected value.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Main PR
Kapture.2022-03-23.at.19.54.16.mp4
Kapture.2022-03-23.at.19.53.18.mp4

@sean-perkins sean-perkins requested a review from a team March 23, 2022 23:55
@github-actions github-actions bot added the package: core @ionic/core package label Mar 23, 2022
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we post a dev build on the issue thread and collect feedback prior to merging?

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the below comment is addressed 👍

@gee1k
Copy link

gee1k commented Apr 2, 2022

Thank you for your hard work! i need it, Please merge it

@liamdebeasi
Copy link
Contributor

@sean-perkins We can merge this once the branch is synced with main. I think we gave developers plenty of times to test, and both Amanda and I have found no issues with the PR.

@sean-perkins sean-perkins merged commit 8318659 into main Apr 4, 2022
@sean-perkins sean-perkins deleted the FW-19 branch April 4, 2022 18:47
@liamdebeasi liamdebeasi mentioned this pull request Dec 6, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants