Skip to content

fix(datetime): month picker no longer gives duplicate months on ios 14 and older #24792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liamdebeasi merged 13 commits into from
Feb 23, 2022
Merged

fix(datetime): month picker no longer gives duplicate months on ios 14 and older #24792

liamdebeasi merged 13 commits into from
Feb 23, 2022

Conversation

@liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 15, 2022 •
edited
Loading

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue URL: resolves #24663

What is the new behavior?

  • Force all timezones to be interpreted as UTC when formatting.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from a team February 15, 2022 18:40
@github-actions github-actions bot added the package: core @ionic/core package label Feb 15, 2022
@liamdebeasi liamdebeasi merged commit b6d7e1c into main Feb 23, 2022
@liamdebeasi liamdebeasi mentioned this pull request Feb 23, 2022
Closed
6 tasks
@liamdebeasi liamdebeasi deleted the FW-656 branch February 23, 2022 13:43
This was referenced Mar 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sean-perkins sean-perkins Awaiting requested review from sean-perkins

1 more reviewer

@averyjohnston averyjohnston averyjohnston approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

package: core @ionic/core package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: ion-datetime duplicates some months when below a certain year on iOS 14

4 participants

@liamdebeasi @sean-perkins @averyjohnston