fix(vue): inherit class attribute on ion-page

[bnachtweh]

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Class attribute is not inherited by the ion-page component

Issue Number: # 24772

What is the new behavior?

• The ion-page component inherits class attribute

Does this introduce a breaking change?

• Yes
• No

Other information

[liamdebeasi]

Thanks for the PR! We appreciate your contribution to Ionic.

I wanted to make some changes to the tests, but I was unable to push to your branch so I created #24776. The code is more or less the same, but I made spec tests instead of E2E tests. We can get the same checks with spec tests, but they run a bit faster than the E2E ones.

I will give you co-author credit when #24776 merges.

[bnachtweh]

Thanks for the PR! We appreciate your contribution to Ionic.

I wanted to make some changes to the tests, but I was unable to push to your branch so I created #24776. The code is more or less the same, but I made spec tests instead of E2E tests. We can get the same checks with spec tests, but they run a bit faster than the E2E ones.

I will give you co-author credit when #24776 merges.

Thank you very much! The code is indeed as good as the same. I've added some tests for the absence of a custom added class attribute and an object class attribute. It's not critical, but I figured it prevents stuff as class="undefined" from happening, should someone for whatever reason choose to make changes to this component. Your PR also looks fine by me!

[liamdebeasi]

Thanks! Closing in favor of #24776. I gave you co-author credit on the commit.

This fix should be in the next release of Ionic.