Skip to content

Conversation

@matzar
Copy link
Contributor

@matzar matzar commented Feb 10, 2022

Changed '==' to '===' in infinite-scroll readme.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Updated documentation so people don't get scared when seeing '==' equality.

Issue Number: #

What is the new behavior?

Changed '==' to '===' in infinite-scroll Usage code example.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Expected '===' instead saw '=='.
@matzar matzar requested a review from a team February 10, 2022 14:54
@github-actions github-actions bot added the package: core @ionic/core package label Feb 10, 2022
Copy link
Contributor

@sean-perkins sean-perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 5 occurrences of this issue in this file. Can you please update all of them at once? Thanks!

@matzar matzar requested a review from sean-perkins February 11, 2022 11:23
@matzar matzar changed the title fix(readme.md): double equality docs(readme.md): double equality Feb 11, 2022
Copy link
Contributor Author

@matzar matzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double checked everything - 5 occurences of double-equals have been replaced with tripple-equals.

@averyjohnston
Copy link
Contributor

Thanks for the PR! The readme file you've updated is mostly auto-generated (everything below the <!-- Auto Generated Below --> comment) and will be overwritten when build is run. The source files for the usage examples are under infinite-scroll/usage. Could you update those instead, and then run npm run build to propagate the changes to the auto-generated files (and commit those updates as well)?

Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This LGTM once tests pass and Sean has a chance to take another look.

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the package-lock changes?

@matzar
Copy link
Contributor Author

matzar commented Feb 16, 2022

Can we remove the package-lock changes?

Now I've commited only infinite-scroll/usage changes and built readme. No package-lock.jsons or api.txt.

@matzar matzar requested a review from liamdebeasi February 16, 2022 10:13
@liamdebeasi liamdebeasi changed the title docs(readme.md): double equality docs(infinite-scroll): use proper equality check Feb 22, 2022
@averyjohnston averyjohnston merged commit 1c3b379 into ionic-team:main Feb 22, 2022
@matzar matzar deleted the patch-1 branch February 23, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants