fix(datetime): improve datetime sizing in modals #24762
Merged
+289
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averyjohnston
approved these changes
Feb 11, 2022
Contributor
averyjohnston
left a comment
averyjohnston
left a comment
There was a problem hiding this comment.
Nice find 👀 Incidentally, this also seems to fix #23985; it even looks good on Firefox.
sean-perkins
changed the title
liamdebeasi
changed the title
liamdebeasi
approved these changes
Feb 15, 2022
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Tested on iOS 14 + 15 and works well.
liamdebeasi
suggested changes
Feb 16, 2022
Contributor
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
Just had a thought... can we add a test to verify this fixed behavior too? #24762 (review)
Contributor
Author
I was unable to replicate that issue in Chrome (the original reported issue) or in Firefox (the follow-up comment). I believe the original issue was a Chrome specific version that has since been fixed. I can add a smoke test though, just to make sure it works with a zoom in/out active. |
liamdebeasi
approved these changes
Feb 22, 2022
6 tasks
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
When an
ion-datetimehas a sub-pixel width (either explicitly or through an auto-sizing layout), the intersection observer is unable to detect the intersecting threshold of 100% (1).This results in the month navigation breaking, months updating sporadically on click and overall broken functionality.
Issue Number: #23992
What is the new behavior?
By applying a root margin to the intersection observer of
1px, it accounts for the difference of the sub-pixel sizing and appropriately fires the intersection observer when the month is intersecting.This fixes all the broken behavior with the calendar month not appropriately updating.
Does this introduce a breaking change?
Other information