Skip to content

fix(input): cursor position does not jump to end #24736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-perkins merged 2 commits into from
Feb 8, 2022
Merged

fix(input): cursor position does not jump to end #24736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae7da31
fix(input): cursor position does not jump to end
sean-perkins Feb 8, 2022
c992f7d
chore(): add tech debt task for iOS 15.3 patch
sean-perkins Feb 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/components/input/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,11 @@ export class Input implements ComponentInterface {
* Used for patterns such as input trimming (removing whitespace),
* or input masking.
*/
this.nativeInput.value = this.getValue();
const { selectionStart, selectionEnd } = this.nativeInput;
this.nativeInput.value = this.getValue();
// TODO: FW-727 Remove this when we drop support for iOS 15.3
// Set the cursor position back to where it was before the value change
this.nativeInput.setSelectionRange(selectionStart, selectionEnd);
}
this.emitStyle();
this.ionChange.emit({ value: this.value == null ? this.value : this.value.toString() });
Expand Down