fix(input): IME composition mode #24735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The community member that reported the issue attached to this PR, commented that the dev build of this PR resolves their issue: #24669 (comment) |
liamdebeasi
suggested changes
Feb 8, 2022
averyjohnston
approved these changes
Feb 8, 2022
Contributor
averyjohnston
left a comment
averyjohnston
left a comment
There was a problem hiding this comment.
LGTM once Liam's comments are addressed 👍
This was referenced Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
IMEs (input method editors) intercept keyboard events and conflict with the patch in #24606, since both are assigning a value to the native input, resulting in duplicate values on keypress. This also breaks the back button behavior (observed in Japanese IME).
Issue Number: #24669
What is the new behavior?
To prevent conflicts with IMEs and preserve the patch from the PR that introduced the new issue, it is recommended that we bind event listeners to
compositionstartandcompositionendto detect when a composition event from an IME is occurring and skip writing the value to the native input control while the event is in flight (inspired from: ng-select/ng-select#1274)Does this introduce a breaking change?
Other information
While triaging this issue, a Stencil bug was discovered (stenciljs/core#3235) that prevents using the JSX bindings for the composition events.
To verify this issue, you can temporarily add a Japanese keyboard to your iOS device and open the basic input test in the browser. A guide on how to add the keyboard is available here: https://techwiser.com/use-japanese-keyboard-iphone.