Skip to content

fix(action-sheet): background includes safe area margin #24700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sean-perkins merged 2 commits into from
Feb 7, 2022
Merged

fix(action-sheet): background includes safe area margin #24700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78f1a30
fix(action-sheet): background includes safe area margin
sean-perkins Feb 2, 2022
840b048
fix(): iOS vs. MD differences
sean-perkins Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/components/action-sheet/action-sheet.ios.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@
text-align: $action-sheet-ios-text-align;
}

// iOS Action Sheet Wrapper
// ---------------------------------------------------

.action-sheet-wrapper {
@include margin(var(--ion-safe-area-top, 0), auto, var(--ion-safe-area-bottom, 0), auto);
}

// iOS Action Sheet Container
// ---------------------------------------------------

Expand Down
8 changes: 8 additions & 0 deletions core/src/components/action-sheet/action-sheet.md.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,14 @@
--color: #{$action-sheet-md-title-color};
}


// Material Design Action Sheet Wrapper
// -----------------------------------------

.action-sheet-wrapper {
@include margin(var(--ion-safe-area-top, 0), auto, 0, auto);
}

.action-sheet-title {
@include padding($action-sheet-md-title-padding-top, $action-sheet-md-title-padding-end, $action-sheet-md-title-padding-bottom, $action-sheet-md-title-padding-start);

Expand Down
2 changes: 1 addition & 1 deletion core/src/components/action-sheet/action-sheet.md.vars.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ $action-sheet-md-background-color: $overlay-md-background-c
$action-sheet-md-padding-top: 0 !default;

/// @prop - Padding bottom of the action sheet
$action-sheet-md-padding-bottom: 0 !default;
$action-sheet-md-padding-bottom: var(--ion-safe-area-bottom) !default;


// Action Sheet Title
Expand Down
1 change: 0 additions & 1 deletion core/src/components/action-sheet/action-sheet.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@

.action-sheet-wrapper {
@include position(null, 0, 0, 0);
@include margin(var(--ion-safe-area-top, 0), auto, var(--ion-safe-area-bottom, 0), auto);
@include transform(translate3d(0, 100%, 0));

display: block;
Expand Down