Skip to content

Conversation

@sean-perkins
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The time picker display ignores the value of hour cycle. The time picker will also restrict all hour selections to the minimum minute range; even though the time is above the min range.

i.e.: When the minimum time is 19:30, you are unable to select any value under 20:30 when the hour is 20.

Issue Number: Resolves #24474

What is the new behavior?

  • Time picker will return the hours back in 24 hour format when hourCycle is h23
  • Time picker allows minute selection above the min range, when the hour is above the min hour (if specified)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Before After
Kapture.2021-12-22.at.14.58.09.mp4
Kapture.2021-12-22.at.14.38.31.mp4

@sean-perkins sean-perkins requested a review from a team December 22, 2021 19:59
@github-actions github-actions bot added the package: core @ionic/core package label Dec 22, 2021
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just one minor thing and then it's a ✅ from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ion-datetime timepicker does not respect hour cycle format with min provided

4 participants