fix(): overlays now present correctly when using custom elements build #23039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicb
reviewed
Mar 12, 2021
vicb
reviewed
Mar 12, 2021
vicb
reviewed
Mar 12, 2021
vicb
reviewed
Mar 12, 2021
vicb
reviewed
Mar 13, 2021
vicb
reviewed
Mar 13, 2021
| } | ||
| }); | ||
|
|
||
| const component = document.createElement('hello-world'); |
Contributor
There was a problem hiding this comment.
nit: use "eager-component" / "lazy-component" instead of "hello-world" ?
Contributor
Author
There was a problem hiding this comment.
The lazy vs non lazy difference is already noted in the name of the test, so not sure this change would make much of a difference.
Contributor
|
Thanks a lot for working on this @liamdebeasi |
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: resolves #23029
What is the new behavior?
Does this introduce a breaking change?
Other information