Skip to content

test(): update theming test with latest dark mode values #22956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liamdebeasi merged 2 commits into from
Feb 23, 2021
Merged

test(): update theming test with latest dark mode values #22956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9b2115
update item background
liamdebeasi Feb 22, 2021
63c12e4
Merge remote-tracking branch 'origin/master' into item-bg
liamdebeasi Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/themes/test/css-variables/css/dark.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,4 +132,5 @@ ion-modal.ios {
--ion-background-color: var(--ion-color-step-100);
--ion-toolbar-background: var(--ion-color-step-150);
--ion-toolbar-border-color: var(--ion-color-step-250);
--ion-item-background: var(--ion-color-step-150);
}
22 changes: 18 additions & 4 deletions core/src/themes/test/css-variables/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -924,6 +924,9 @@ <h2>Street Fighter II</h2>
<ion-header translucent="true">
<ion-toolbar>
<ion-title>Super Modal</ion-title>
<ion-buttons slot="start">
<ion-button class="dismiss">Close</ion-button>
</ion-buttons>
</ion-toolbar>
</ion-header>
<ion-content fullscreen="true">
Expand All @@ -932,10 +935,21 @@ <h2>Street Fighter II</h2>
<ion-title size="large">Super Modal</ion-title>
</ion-toolbar>
</ion-header>
<div class="ion-padding">
<h1>Content of doom</h1>
<div>Here's some more content</div>
<ion-button class="dismiss">Dismiss Modal</ion-button>

<br />

<div>
<ion-list>
<ion-item>
<ion-label>Item A</ion-label>
</ion-item>
<ion-item>
<ion-label>Item B</ion-label>
</ion-item>
<ion-item>
<ion-label>Item C</ion-label>
</ion-item>
</ion-list>
</div>
</ion-content>
`;
Expand Down