-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(custom-elements): add experimental custom elements build #22863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c96303b
feat(custom-elements): add custom element build
adamdbradley e257532
stencil dep
adamdbradley 9902b05
npm7
adamdbradley 9ba94bf
add @jest/core as dev dep
adamdbradley bdc0b59
Merge branch 'master' into custom-elements
adamdbradley 6b1af4d
Update package-lock.json
adamdbradley 7c6e48e
lint fixes
adamdbradley f771593
fix syntax
adamdbradley e25a290
whateves
adamdbradley 733cb53
fix componentOnReady
adamdbradley 854f980
waitForTimeout
adamdbradley d76536d
make updateOptions async
liamdebeasi bda1ed8
add comment
liamdebeasi f7d6f1b
remove extra logs
liamdebeasi 5679248
lint
liamdebeasi 7e21c6b
add missing async
liamdebeasi 7ef5043
bump ionicons
liamdebeasi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anything else to do beside calling
initialize()and registering the components ?I am trying this feature of 5.6 and have a few issues:
-The body is initially hidden[1],
modalControllerfrom@ionic/core/componentsand registeringion-modal(IonModal) +ion-backdrop,<ion-select>that is not rendering (supposed to be a popover)[1] because of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you file an issue with a reproduction regarding the overlays not working?
For the css, you can add the following globally for now:
We did not remove that for now since it would impact non-custom element build versions of Ionic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your super fast answer.
I have added the class to my html for now.
I'll dig a little bit in the overlay issue trying to find the root cause and I'll create an issue with a repro.