Skip to content

Custom elements bundle #22641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
claviska wants to merge 41 commits into from
Closed

Custom elements bundle #22641

claviska wants to merge 41 commits into from

Conversation

@claviska
Copy link

@claviska claviska commented Dec 8, 2020

This adds the dist-custom-elements-bundle to the framework so users can import components as described in the Stencil docs as opposed to the default lazy loader.

It also moves types from src/interface.d.ts to /src/index.ts.

adamdbradley and others added 30 commits May 29, 2020 10:46
@adamdbradley
chore: readme, types, api updates from stencil and ts 3.9.3 update
114fa24
@adamdbradley
feat(custom-elements): add custom elements output target
65d667d
@adamdbradley
chore: gitignore @ionic/core/components build
2299424
@adamdbradley
stencil 1.14.0
73c0d1b
@adamdbradley
Merge branch 'master' into customelements
a55f52e
@adamdbradley
Merge branch 'master' into customelements
fb139cf
@adamdbradley
update to stencil 1.15.0-1
1550bd6
@adamdbradley
Merge branch 'master' into customelements
465c641
@adamdbradley
wip
e21f69e
@adamdbradley
Merge branch 'master' into customelements
e78fc0c
@adamdbradley
🍔
c811ab8
@adamdbradley
dedupe
0fef852
@adamdbradley
test dist
7cbb599
@adamdbradley
stencil 1.16.0-1
f11d6f1
@adamdbradley
Merge branch 'master' into customelements
0bb03b2
@adamdbradley
Merge branch 'master' into customelements
b82870c
@adamdbradley
bump deps
798881b
@adamdbradley
Merge branch 'master' into customelements
03a5be5
@adamdbradley
fix(overlays): move prepareOverlay to connectedCallback
385bcfe
@adamdbradley
chore(stencil): bump to stencil 1.16.4
79cfffb
@adamdbradley
Merge branch 'master' into customelements
3aa7363
@adamdbradley
"@stencil/core": "^2.0.0-3"
0eea99f
@adamdbradley
wip
7c29410
@adamdbradley
node 14
1772b69
@adamdbradley
package updates
07711fd
@adamdbradley
Merge branch 'master' into customelements
2cc6169
@adamdbradley
package updates
6542f78
@claviska
Merge remote-tracking branch 'origin/customelements' into custom-elem…
987733c 
…ents-bundle
@claviska
chore(): move custom elements output to dist
7ebad74
@claviska
chore(): move types from interface.d.ts to index.ts
0e063cb
@claviska claviska added type: feature request a new feature, enhancement, or improvement review: needs review labels Dec 8, 2020
@github-actions github-actions bot added the package: core @ionic/core package label Dec 8, 2020
@claviska claviska requested a review from liamdebeasi December 8, 2020 16:15
@claviska
Copy link
Author

claviska commented Dec 11, 2020

Closing this in favor of #22665 because this would require us to upgrade Angular's TypeScript which would be a breaking change for some users.

@claviska claviska closed this Dec 11, 2020
@claviska claviska deleted the custom-elements-bundle branch December 11, 2020 20:34
@claviska claviska restored the custom-elements-bundle branch December 14, 2020 16:49
@claviska claviska deleted the custom-elements-bundle branch December 14, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liamdebeasi liamdebeasi Awaiting requested review from liamdebeasi

Assignees

No one assigned

Labels

package: core @ionic/core package type: feature request a new feature, enhancement, or improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@claviska @adamdbradley