feat(refresher): refresher now correctly styled in dark mode #22639
Conversation
liamdebeasi
left a comment
liamdebeasi
left a comment
There was a problem hiding this comment.
This looks great, thank you! When comparing to the refresher built in to Android, the arrow seems a bit lighter on dark mode, but I don't think that's a huge deal. cc @brandyscarney Thoughts?
liamdebeasi
changed the title
|
Brandy pointed out that this adds 2 new CSS variables, |
liamdebeasi
changed the title
|
Hey there, I made a few changes to your PR. After discussing with the team, we removed the Your PR is good to go, so I will be merging one the build passes. Thanks! |
|
Merged. Thank you! |
* master: (284 commits) fix(label): only show placeholder with floating label when focused (ionic-team#22958) feat(react): add react hooks to control overlay components (ionic-team#22484) feat(vue): add composition API ionic lifecycle hooks (ionic-team#22970) chore(): run build 5.5.5 fix(vue): account for event name changes in vue 3.0.6+ fix(react, vue): navigating using ion-back-button now selects correct page (ionic-team#22974) fix(progress-bar): use correct theme colors in dark mode (ionic-team#22965) fix(progress-bar): add width transition (ionic-team#22964) fix(vue): prevent race conditions when opening overlays (ionic-team#22883) fix(progress-bar): use correct theme colors in dark mode (ionic-team#22957) feat(searchbar): add showClearIcon property (ionic-team#22759) test(): update theming test with latest dark mode values (ionic-team#22956) chore(): update package-lock to account for npm 7.5.3 bug fix (ionic-team#22963) fix(header): collapsed toolbar is no longer incorrectly shown when using ion-refresher (ionic-team#22937) fix(react): onIonTabsWillChange and onIonTabsDidChange event handlers are now properly bound to IonTabs (ionic-team#22233) fix(refresher): add correct dark mode styles (ionic-team#22639) feat(custom-elements): add experimental custom elements build (ionic-team#22863) fix(a11y): improve support for ids with special characters when getting label element (ionic-team#22680) chore(): update code of conduct (ionic-team#22619) ...
2 participants
closes #22637
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
ion-refresh for material design does not have a dark mode
Issue Number: #22637
What is the new behavior?
ion-refresher for material design displays nicely on dark mode
The refresher color was hardcoded as
whitefor the background and#ecececfor the border.This change introduce a 3 steps fallback:
--ion-refresher-background(this is a new variable), of fallback to--ion-color-step-250, or fallback to#ffffff(original color)--ion-refresher-border-color(this is a new variable), of fallback to--ion-color-step-200, or fallback to#ececec(original color)Does this introduce a breaking change?
Other information
I didn't find an easy way to run the stencil tests with dark mode so I just quickly added the dark mode config from the doc in
core/scripts/testing/styles.css(didn't commit this obviously :D )What's the proper way run the tests in dark mode?
Also should the 2 new variables
--ion-refresher-background&--ion-refresher-border-colorbe documented somewhere? In the component page? In the dark mode page?