Skip to content

Conversation

@xauuug
Copy link
Contributor

@xauuug xauuug commented Nov 28, 2020

Fix skeleton-text component vue usage example

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The skeleton-text usage example is broken.

Issue Number: N/A

What is the new behavior?

The skeleton-text vue use example now works correctly.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: core @ionic/core package label Nov 28, 2020
@liamdebeasi
Copy link
Contributor

Thank you! To get these tests to pass, you will need to run npm run build and push your changes.

@liamdebeasi liamdebeasi merged commit 0be79fe into ionic-team:master Dec 3, 2020
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

@xauuug xauuug deleted the skeleton-text-vue-usage branch December 3, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants