fix(all): component reusage #18963
Merged
fix(all): component reusage #18963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucorporat
force-pushed
the
fix-ionic-reattaching
branch
from
08008f0 to
c9bf60c
Compare
manucorporat
commented
Aug 1, 2019
core/src/components/menu/menu.tsx
Outdated
| // register this menu with the app's menu controller | ||
| menuCtrl!._register(this); | ||
|
|
||
| this.updateState(); |
Contributor
Author
There was a problem hiding this comment.
i might need to move back to didLoad(), will test
adamdbradley
reviewed
Aug 1, 2019
Member
|
Ran into a couple of issues while testing: ReorderI am getting an error on the item/reorder test: http://localhost:3333/src/components/item/test/reorder Routerhttp://localhost:3333/src/components/router/test/basic This test has a blank screen ^ |
manucorporat
force-pushed
the
fix-ionic-reattaching
branch
from
28bd97c to
71bf2f2
Compare
manucorporat
force-pushed
the
fix-ionic-reattaching
branch
from
71bf2f2 to
bcc8b3f
Compare
liamdebeasi
pushed a commit
that referenced
this pull request
Aug 27, 2019
brandyscarney
pushed a commit
that referenced
this pull request
Aug 27, 2019
Contributor
|
@manucorporat |
Contributor
Author
|
@DavidStrausz can you open an issue explaining how to reproduce? |
Contributor
|
@manucorporat I can but this will take some time, just thought you might want a heads up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18843
fixes #17344
fixes #16453
fixes #15879
fixes #15788
fixes #15484
fixes #17890
fixes #16364
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information