fix(item-option): styling and behaviour for disabled item-option #17909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
changed the title
liamdebeasi
approved these changes
Mar 28, 2019
|
Hey @liamdebeasi - shoot, I missed that part. Thanks for adding it! 🙂 |
brandyscarney
approved these changes
Mar 28, 2019
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
This fixes the linked bug whereby the
disabledattribute was not working on theion-item-optioncomponent. This PR includes the styling and applies the disabled class to the component.Changes proposed in this pull request:
item-option-disabledclass to the component.disabledoption.Ionic Version: 4.1.2
Fixes: #17905