fix(angular): account for replaceUrl option #17879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
damn i just thought of a PR and now i have to see this one :D. Nice thing ;) |
mhartington
approved these changes
Mar 29, 2019
|
LGTM, squash and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
There was an issue where our StackController was not taking into account
replaceUrl. So when going from page A->page B->page C (replace url), page B was still in the stack. Going back viaion-back-buttonfrom page C would go back to page B, whereas going back from page C via the browser back button would go back to page A.Changes proposed in this pull request:
replaceUrlon current navigation when inserting the new viewIonic Version:
Fixes: #15181