-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Closed
Labels
package: angular@ionic/angular package@ionic/angular packagetype: buga confirmed bug reporta confirmed bug report
Description
Prequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
- v4.x
- v5.x
- v6.x
Current Behavior
After creating an Nx workspace, running the ng add @ionic/angular command to setup Ionic for the default project fails. This is due to the test target options requiring an assets property. This property is not present in a new Nx workspace due to it using Jest instead of Karma.
Expected Behavior
The schematic completes successfully for projects not using Karma, or not using an assets property in the test target options.
Steps to Reproduce
- Create a new Nx workspace
npx create-nx-workspace@latest nxionic --preset angular
cd nxionic- Run schematic to add Ionic
ng add @ionic/angular- Note the error
✔ Package successfully installed.
"ionicNgAdd" schema is using the keyword "id" which its support is deprecated. Use "$id" for schema ID.
Cannot read property 'push' of undefined
Code Reproduction URL
https://github.com/brandonroberts/nx-ionic-ng-add
Ionic Info
No response
Additional Information
I'll put in a PR to fix
Metadata
Metadata
Assignees
Labels
package: angular@ionic/angular package@ionic/angular packagetype: buga confirmed bug reporta confirmed bug report