Skip to content

chore: remove trailing slash to avoid flash of 404 page #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

chore: remove trailing slash to avoid flash of 404 page #3484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd33f66
chore: remove trailing slash to avoid flash of 404 page
liamdebeasi Feb 28, 2024
c19efff
Update docusaurus.config.js
liamdebeasi Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docusaurus.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ const VERSIONS_JSON = require('./versions.json');
* that are built with Docusaurus. The
* Ionic v3 and v4 docs are built with other tools, so those
* versions are not included here.
*
* Note that the urls specified in this file should
* NOT have a trailing slash otherwise users will
* briefly get a 404 Page Not Found error before
* the docuementation website loads.
*/
const ARCHIVED_VERSIONS_JSON = require('./versionsArchived.json');

Expand Down
2 changes: 1 addition & 1 deletion versionsArchived.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"v5": "https://ionic-docs-5utg8ms4c-ionic1.vercel.app/docs/v5/"
"v5": "https://ionic-docs-5utg8ms4c-ionic1.vercel.app/docs/v5"
}