Skip to content

Conversation

mapsandapps
Copy link
Contributor

@mapsandapps mapsandapps commented Aug 24, 2023

See FW-4717 and design doc update for extra context.

Previously, you couldn't create a playground for animations, gestures, etc., without using some workarounds. Now the prompts ask if you're creating a playground for a component or not and adjust the other prompt questions accordingly.

⚠️ I also did a little refactoring & renaming to make the code more clear. Walking through the commits one-by-one may help for review.

I included an ion-card in the templates, since the animation playgrounds tend to have those.

Improve console.log copy
Adjust templates for non-component playground generation

Adjust templates for non-component playground generation
@vercel
Copy link

vercel bot commented Aug 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 1:26pm

@mapsandapps mapsandapps changed the title feat(generation): generate playgrounds for non-components feat(generation): generate playgrounds for guides Aug 25, 2023
@mapsandapps mapsandapps marked this pull request as ready for review August 25, 2023 17:22
@mapsandapps mapsandapps requested review from a team and brandyscarney and removed request for a team August 25, 2023 17:26
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mapsandapps mapsandapps merged commit f593596 into main Aug 28, 2023
@mapsandapps mapsandapps deleted the FW-4717 branch August 28, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants