-
Notifications
You must be signed in to change notification settings - Fork 3.2k
docs(slides): remove ion-slides component #2518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What do you think we should do about the "Slides" card on https://ionicframework.com/docs/components? Maybe we should keep the |
Can we remove this section from the FAQ for each framework:
|
Hmm, I'm thinking we just remove the card entirely, since we're handing things off fully to a 3rd party library 🤔 The recommendation will be linked in the breaking changes guide, which may be enough? What do you think? We can always revisit if we start getting questions/feature requests about slides/carousels. I'm hesitant to keep the component pages because it feels like unnecessary clutter. |
You may be getting |
@liamdebeasi @sean-perkins Not sure how notifications work in this situation 😆 |
That's probably fine. We do have "Slides" pages for each framework integration. |
You could also ask Ben and see what he thinks too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to remove the "Slides" option from https://ionic-docs-git-fw-1363-ionic1.vercel.app/docs/components and we will be good to go.
In v7, we are removing
ion-slides
,ion-slide
, andIonicSwiper
. In accordance with this, this PR:Corresponding framework PR: #2507