Skip to content

docs(slides): remove ion-slides component #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Conversation

averyjohnston
Copy link
Contributor

In v7, we are removing ion-slides, ion-slide, and IonicSwiper. In accordance with this, this PR:

  • Removes the component docs
  • Removes links to the components from the sidebar
  • Updates the framework-specific migration docs with callouts

Corresponding framework PR: #2507

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ionic-docs ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 8:29PM (UTC)

@liamdebeasi
Copy link
Contributor

liamdebeasi commented Aug 31, 2022

What do you think we should do about the "Slides" card on https://ionicframework.com/docs/components?

Maybe we should keep the ion-slides page and reference the framework-specific pages in the content? I do worry that the Swiper.js recommendation will be a bit buried.

@sean-perkins
Copy link
Contributor

Can we remove this section from the FAQ for each framework:

If you are running into problems with the IonicSlides module, new bugs should be filed on the Ionic Framework repo: https://github.com/ionic-team/ionic-framework/issues

@averyjohnston
Copy link
Contributor Author

What do you think we should do about the "Slides" card on https://ionicframework.com/docs/components?

Maybe we should keep the ion-slides page and reference the framework-specific pages in the content? I do worry that the Swiper.js recommendation will be a bit buried.

Hmm, I'm thinking we just remove the card entirely, since we're handing things off fully to a 3rd party library 🤔 The recommendation will be linked in the breaking changes guide, which may be enough? What do you think?

We can always revisit if we start getting questions/feature requests about slides/carousels. I'm hesitant to keep the component pages because it feels like unnecessary clutter.

@averyjohnston
Copy link
Contributor Author

Can we remove this section from the FAQ for each framework:

If you are running into problems with the IonicSlides module, new bugs should be filed on the Ionic Framework repo: https://github.com/ionic-team/ionic-framework/issues

You may be getting IonicSlides and IonicSwiper confused? We're keeping IonicSlides.

@averyjohnston
Copy link
Contributor Author

@liamdebeasi @sean-perkins Not sure how notifications work in this situation 😆

@liamdebeasi
Copy link
Contributor

Hmm, I'm thinking we just remove the card entirely, since we're handing things off fully to a 3rd party library 🤔 The recommendation will be linked in the breaking changes guide, which may be enough? What do you think?

We can always revisit if we start getting questions/feature requests about slides/carousels. I'm hesitant to keep the component pages because it feels like unnecessary clutter.

That's probably fine. We do have "Slides" pages for each framework integration.

@liamdebeasi
Copy link
Contributor

You could also ask Ben and see what he thinks too

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to remove the "Slides" option from https://ionic-docs-git-fw-1363-ionic1.vercel.app/docs/components and we will be good to go.

@averyjohnston averyjohnston merged commit 108db22 into release-7.0 Sep 2, 2022
@averyjohnston averyjohnston deleted the FW-1363 branch September 2, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants