-
Notifications
You must be signed in to change notification settings - Fork 11
fix(ios): prevent alert view dismiss from triggering onBrowserClosed event #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Isn't it missing package.swift update? |
Since we're using |
Yes, but shouldn't we make sure the native code is the most up-to-date?
I suppose that it isn't a big deal since the bug isn't "severe". But still. Let me know if what I said makes sense |
You're right, we should make sure the native code is using the most up-to-date version. The To make things clearer, we could either:
What do you think? |
|
I think because the plugin code is tightly coupled to the native library - in the sense that updates to the library will almost always result in new versions in the plugin - maybe What is the experience for existing plugin clients using SPM when we update the dependency on the native library (not very relevant for this plugin right now, but relevant for future versions) - will |
66072e6 to
024f869
Compare
# [2.5.0](v2.4.0...v2.5.0) (2025-09-16) ### Bug Fixes * **ios:** prevent alert view dismiss from triggering onBrowserClosed event ([#83](#83)) ([101a1d2](101a1d2)) * **ios:** use version instead of branch for SPM ([#80](#80)) ([2765458](2765458)) ### Features * add OSInAppBrowserLib-iOS dependency ([5ada205](5ada205)) * example app with spm ([d3bd8f2](d3bd8f2))
# [3.0.0-next.2](v3.0.0-next.1...v3.0.0-next.2) (2025-10-08) ### Bug Fixes * **ios:** allow iframe content to load in webview ([#86](#86)) ([193ce0a](193ce0a)) * **ios:** prevent alert view dismiss from triggering onBrowserClosed event ([#83](#83)) ([101a1d2](101a1d2)) * **ios:** use version instead of branch for SPM ([#80](#80)) ([2765458](2765458)) ### Features * add OSInAppBrowserLib-iOS dependency ([5ada205](5ada205)) * **android:** allow for photo and video capturing and filter for media type for file uploads (onShowFileChooser) ([c696bd2](c696bd2)) * example app with spm ([d3bd8f2](d3bd8f2))
This PR fixes an issue where dismissing an alert view triggered the onBrowserClosed event.