Handle optional TimeoutError attributes
#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #85 +/- ##
==========================================
- Coverage 97.03% 96.78% -0.26%
==========================================
Files 9 9
Lines 743 746 +3
Branches 51 53 +2
==========================================
+ Hits 721 722 +1
Misses 17 17
- Partials 5 7 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ionelmc
added a commit
that referenced
this pull request
Nov 12, 2025
Owner
|
Released 3.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dask/distributed#9140 we are seeing a problem in our CI with newer versions of
tblib.It looks like this was partially fixed in #83 but the same applies to other attributes of
OSErrorsubclasses likeTimeoutError, e.gerrornoandstrerror. If the value of them isNonethey should not be set at all otherwise it will break the string representation.