[typing] Better typing in main.ts #2911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch potential error in `writeBaseSettings`
Apollon77
reviewed
Sep 19, 2024
packages/controller/src/main.ts
Outdated
| } catch { | ||
| error = `Cannot write file ${configFile}`; | ||
| } | ||
| } else { |
Collaborator
There was a problem hiding this comment.
This now overrides the error from "L2872" ... is this intended?
Apollon77
approved these changes
Sep 19, 2024
foxriver76
requested changes
Sep 21, 2024
packages/controller/src/main.ts
Outdated
| error = `Cannot write file ${configFile}`; | ||
| } | ||
| } else if (!error) { | ||
| error = `Invalid data for writeBaseSettings ${msg.from}`; |
Collaborator
There was a problem hiding this comment.
Hm if we don't have an error yet we will always assign one here.. and the invalid data logged is the msg.from attribute? I think something is wrong here
Collaborator
There was a problem hiding this comment.
Hm okay the logic is okay as it only happens if config is falsy but shouldn't we log the received config then
foxriver76
approved these changes
Sep 21, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| try { | ||
| fs.writeFileSync(configFile, JSON.stringify(config, null, 2)); |
Check failure
Code scanning / CodeQL
Potential file system race condition High
Apollon77
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch potential error in
writeBaseSettingsTyping for writeBaseSettings/readbaseSettings added