Catch generic model errors #4937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent the app from dying on invalid models.
d8ahazard
requested review from
GreggHelt2,
RyanJDick,
StAlKeR7779,
blessedcoolant,
brandonrising,
damian0815,
hipsterusername and
lstein
as code owners
RyanJDick
approved these changes
Oct 18, 2023
Contributor
RyanJDick
left a comment
RyanJDick
left a comment
There was a problem hiding this comment.
Seems reasonable to me. We're already tolerating a bunch of model load errors - might as well tolerate them all.
We should tidy our error handling in this block, but that can be left for a future PR.
Thanks for this contribution!
Contributor
Author
My pleasure! Love the project, doubly so for the new features you guys have been adding. FWIW, it may also be useful to filter "non-checkpoint" models when scanning, I'm getting a lot of errors for custom metadata files I have alongside my models: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent the app from dying on invalid models.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Have you updated all relevant documentation?
Description
Fix multiple potential issues when scanning models on first load, specifically with an instructPix2Pix model and some non-safetensor files.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?
Nope.