Tweaks to Image Progress Node #3833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickr777
requested review from
blessedcoolant,
maryhipp and
psychedelicious
as code owners
blessedcoolant
requested changes
Jul 19, 2023
invokeai/frontend/web/src/features/nodes/components/ProgressImageNode.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/nodes/components/ProgressImageNode.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
I've made some changes. Try them out and see. If they're what you wanted to achieve with this PR, I think it feels good enough for a merge. |
Contributor
Author
yes, it works as expected, was mainly trying to have the progress image not change the size of the node (as it was doing before) and when the user changes the nodes size it is remembered |
Collaborator
|
Seems good. Merging it in. |
blessedcoolant
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
A while Back
Description
Some tweaks to the Progress image Node
Fixed aspect ratio and resize
Added nodesize option to nodeslice
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
have not been included
[optional] Are there any post deployment tasks we need to perform?