ui: improve context menu #3799
Merged
ui: improve context menu #3799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- faster animation - do not handle context menu events inside context menu (fixes issue where the context menu appears to not fire)
- restore copy image functionality* in image context menu, current image buttons - give IAIDndImage the same context menu * copying image to clipboard is not possible on Firefox unless the user enables a setting which is disabled by default. if the browser does not support copying an image, the copy functionality is disabled.
Both support the same actions: - Open in new tab - Copy image (if supported by browser) - Use prompt - Use seed - Use all - Send to img2img - Send to canvas - Change board - Download image - Delete
psychedelicious
requested review from
blessedcoolant and
maryhipp
as code owners
maryhipp
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(ui): improve context menu feel
feat(ui): fix copy image, add context menu to IAIDndImage
feat(ui): consolidate imagecontextmenu and send to menu
Both support the same actions:
Demo (light mode is FF, where copy is not available, dark mode chrome where it available)
Screen.Recording.2023-07-17.at.7.25.29.pm.mov