get uploads working again #3679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 7, 2023 12:02
blessedcoolant
approved these changes
Jul 7, 2023
Collaborator
|
Not a local bug. I have it too. The PR fixes it but I'll let @psychedelicious take a look before the merge coz I'm unfamiliar with this part of the code. |
Contributor
|
Y'all sure you have up to date packages? |
Collaborator
It does. |
Contributor
|
Uploads work for me dragging from filesystem and on canvas - I think there's a dependency issue. Please try |
Contributor
Author
|
I deleted my node modules and installed
On Fri, Jul 7, 2023 at 6:21 PM psychedelicious ***@***.***> wrote:
Uploads work for me dragging from filesystem and on canvas - I think
there's a dependency issue. Please try yarn install --force
—
Reply to this email directly, view it on GitHub
<#3679 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTQFKBPFUJMJNYQZX55643XPCDVZANCNFSM6AAAAAA2CAB5RQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
|
lstein
added a commit
that referenced
this pull request
Jul 8, 2023
I'm not sure if this was just my local install, but even after a fresh `yarn install` my upload network request was failing because no file was passed in. I don't think the `bodySerializer` part is getting run
Contributor
|
This should not have been merged |
Collaborator
|
I am going to create a revert PR for this. Just as a note, before I merged I tested file uploads with and without the patch. Without the patch I got a permission denied error when trying to upload. The patch fixed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this was just my local install, but even after a fresh
yarn installmy upload network request was failing because no file was passed in. I don't think thebodySerializerpart is getting run